rock-5-itx: link upstream kernel commit in pcie3 refclk u-boot patch by SuperKali · Pull Request #9861 · armbian/build

SuperKali · 2026-05-18T19:19:06Z

Summary

Follow-up to #9848. Adds a reference to Heiko Stuebner's Linux mainline commit e684f02492f9 ("arm64: dts: rockchip: fix the pcie refclock oscillator on Rock 5 ITX") in the commit message of the u-boot dtsi override, so reviewers can see the kernel-side rationale for the pcie30_port{0,1}_refclk gated-fixed-clock node we work around in U-Boot.

Suggested by @rpardini in #9848 (comment).

No code change, message-only.

Test plan

patch --dry-run still applies cleanly against U-Boot v2026.04
Rebuild + flash on Rock 5 ITX, NVMe boot still works (unchanged from rock-5-itx: switch to mainline u-boot v2026.04 #9848)

Summary by CodeRabbit

Documentation
- Added reference documentation to bootloader configuration patch linking to corresponding upstream commits and maintenance resources.

@rpardini

Add a reference to Heiko's Linux mainline commit e684f02492f9 that introduced the pcie30_port{0,1}_refclk gated-fixed-clock on this board, so reviewers of the U-Boot dtsi override can see the kernel-side rationale. Suggested by @rpardini on PR armbian#9848. Signed-off-by: SuperKali <hello@superkali.me>

coderabbitai · 2026-05-18T19:19:14Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 71ebd2af-be2b-4e95-bb54-437664524dfd

📥 Commits

Reviewing files that changed from the base of the PR and between 4804150 and 6a464a6.

📒 Files selected for processing (1)

patch/u-boot/v2026.04/board_rock-5-itx/0001-arm-dts-rockchip-rock-5-itx-drop-pcie-refclk-from-u-boot-dtsi.patch

📝 Walkthrough

Walkthrough

This PR adds kernel-side rationale and mainline commit references to the U-Boot patch description for Rock 5 ITX PCIe configuration, improving patch traceability and documentation without altering the DTS diff payload itself.

Changes

Patch description enhancement

Layer / File(s)	Summary
Patch description with kernel rationale `patch/u-boot/v2026.04/board_rock-5-itx/0001-arm-dts-rockchip-rock-5-itx-drop-pcie-refclk-from-u-boot-dtsi.patch`	Patch metadata enriched with kernel-side rationale explaining the PCIe refclock removal, including reference to the corresponding Linux mainline commit and lore archive link for traceability.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

armbian/build#9848: The main PR that includes the functional DTS fix for PCIe refclock configuration in the mainline U-Boot v2026.04 switch; this PR documents and cross-references that same change.

Suggested reviewers

amazingfate
igorpecovnik
catalinii
paolosabatino
Tonymac32
HeyMeco
pyavitz
efectn
NicoD-SBC
ColorfulRhino

Poem

🐰 A patch that explains itself,
With links to kernel lore,
No code was changed, just words refined—
But documentation's what we adore!

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and accurately summarizes the main change: adding a reference to an upstream kernel commit in a U-Boot patch for the Rock 5 ITX board's PCIe clock.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2026-05-18T19:21:12Z

✅ This PR has been reviewed and approved — all set for merge!

HeyMeco · 2026-05-18T19:21:15Z

You should probably send it upstream too.

SuperKali · 2026-05-18T19:22:41Z

@HeyMeco yeah, definitely on the list, if I find the time :)

* main: (403 commits) Improve proxy handling for builds nanopi-r76s: fix SD boot and storage stability on eMMC-less units (armbian#9908) nanopi-m5: drop GMAC rx_delay to fix gigabit RX (armbian#9901) meson64-6.18: rewrite kernel patches against 6.18.33 meson64-7.0: rewrite kernel patches against 7.0.10 rockchip64-7.0: rewrite kernel patches against 7.0.10 rockchip64-6.18: rewrite kernel patches against 6.18.33 sunxi-7.0: rewrite kernel patches against 7.0.10 sunxi-6.18: rewrite kernel patches against 6.18.33 ch13726a: Remove MIPI_DSI_MODE_VIDEO_BURST rockchip64-bleedingedge: re-enable rtl8723ds wifi driver rtl8723ds: remove guard against *bleedingedge* and update target commit kernel: add 7.1 as edge kernel boards: add mba93xxla-mini boards: add tq-smarc2-tqma8mpxs tqma8m: cleanup patch and board configs u-boot-tqma: update and prepare new boards uwe5622: add patch header briefly explaining the changes uwe5622: add >=7.1 compat patch drivers_network.sh: remove *bleedingedge* BRANCH condition for uwe5622 driver rockchip64-bleedingedge: re-add uwe562x wifi driver to kernel config move Qidi X-6 to mainline u-boot This PR adds official Armbian support for two EasePi IoT gateway/NAS devices (armbian#9880) fix(kernel-debs): allow 'dwarves' as alternative for 'pahole' in headers Depends fix(ci/shellcheck): pass --shell=bash for per-file lint of board configs Automatic: kernel config rewrite build(deps): bump github/codeql-action from 4.35.5 to 4.36.0 build(deps): bump plbstl/first-contribution from 4.3.0 to 4.3.1 `Automatic` board configs status synchronise Rockchip: youyeetoo yy3568: enable pci-e NVMe ssd ci: least-privilege GITHUB_TOKEN in maintenance-lint-scripts-post fix(sm8550-7.0): drop merged & broken SD/DSI patches fix(sm8550-6.18): drop broken sm8x50 UHS-I/xo-clock mbox patch Add wifi to Radxa Cubie A5E (kernel7.0) (armbian#9879) Update odroidxu4-current to 6.6.141 fix(sunxi-6.18): drop r-spi backport from series.conf fix(sunxi-6.18): drop r-spi backport now merged in linux-6.18.y stable fix(sm8250): drop duplicate cpu7_opp21 label on Xiaoxin Pad Pro overclock OPP build(deps): bump step-security/harden-runner from 2.19.3 to 2.19.4 `Automatic` board configs status synchronise Update radxa-cubie-a5e.csc with current kernel for build (armbian#9874) youyeetoo-yy3588: promote from CSC to standard support (armbian#9873) ci: ShellCheck PR comments & auto-fix suggestions workflow tools(shellcheck): SHELLCHECK_INSTALL_ONLY env to skip lint passes fix(tools/shellfmt): include .eos and .wip board configs in formatting scope feat(tools/shellfmt): accept positional file args for scoped format fix(ccache): pass dir-size diff to numfmt past '--' to allow negatives feat(ccache-remote): parse password from DNS-SD TXT for redis backend build(deps): bump tspascoal/get-user-teams-membership interactive: substring filter for the board picker interactive: cache board list across dialog redraws, drop per-file subshells interactive: shfmt whole-file format pass nanopi-r76s: bump mainline u-boot to v2026.04 and drop vendor-branch gates (armbian#9869) Update for Radxa Cubie A5E (armbian#9626) Update odroidxu4-current to 6.6.140 ci: skip build-artifacts gating job on forks `Automatic` board configs status synchronise rock-5-itx: link upstream kernel commit in pcie3 refclk u-boot patch (armbian#9861) rock-5-itx: switch to mainline u-boot v2026.04 (armbian#9848) Automatic: kernel config rewrite `Automatic` board configs status synchronise firmware-sof-signed: move from cli/amd64 baseline to UEFI common build(deps): bump github/codeql-action from 4.35.4 to 4.35.5 build(deps): bump actions/dependency-review-action from 4.9.0 to 5.0.0 build(deps): bump actions/checkout from 4.3.1 to 6.0.2 uefi-x86: enable Intel IPU7 + OV02C10/OV02E10 sensors for LNL ThinkPads uefi-x86: enable SND_SOC_DMIC for SOF DMIC array mic uefi-x86: add CS42L43 MFD/pinctrl/SPI sub-drivers uefi-x86: complete SOF SoundWire chain for LNL ThinkPads uefi-x86: enable iwlwifi MLD + Intel SOF (MTL/LNL/PTL) audio rockchip64-6.18: rebase rk3399 dwc3 phy-reset-quirk patch for 6.18.32 (armbian#9847) rk3528-10-phy-rockchip-inno-usb2: split IS_ERR(rphy->grf) per-branch rk3528-10-phy-rockchip-inno-usb2: fix usbgrf regmap split (6.18 + 7.0 + 7.1) Automatic: kernel config rewrite config: sm8550: Set edge to kernel 7.0 config: kernel: Update sm8550 kernel edge config sm8550: Added kernel 7.0 patches nanopi-m5: pin DRD0 dwc3 to host mode to expose the second USB3 port (armbian#9844) drivers_network: bump rtl8852bs commit ref to 35d3e266 (May 17) mekotronics-r58x-pro: mainline u-boot (and LCD support) also for vendor branch linux-rk35xx-vendor.config: enable `CONFIG_LCD_VK2C21` as module [StepSecurity] Apply security best practices Potential fix for code scanning alert no. 2: Code injection rtl8852bs: re-enable for bleedingedge tools: Bump `ORAS_VERSION` from 1.3.1 to 1.3.2 SpacemiT: Update BPI-F3 DTS SpacemiT: U-Boot: Fixup circular deps SpacemiT: OpenSBI: Fix bool definition Update odroidxu4-current to 6.6.139 [StepSecurity] Apply security best practices rockchip64-6.18: rewrite kernel patches against 6.18.30 rockchip64-7.0: rewrite kernel patches against 7.0.7 sunxi-7.0: rewrite kernel patches against 7.0.7 sunxi-6.18: rewrite patches against 6.18.30 patch/sunxi-6.12: drop dangling series.* references to the same patches patch/sunxi-6.12: drop two Rockchip SPI patches (not applicable to sunxi) rockchip64-edge: add opt-in helios64 CPU stability overlay rockchip64-current: add opt-in helios64 CPU stability overlay NORCO EMB-3531: Switch to rkbin ddr blob to support both DDR3 and LPDDR4X variants NORCO EMB-3531: Enable 4x USB3 Type-A port on LPDDR4X variants ...

@rpardini

…rmbian#9861) Add a reference to Heiko's Linux mainline commit e684f02492f9 that introduced the pcie30_port{0,1}_refclk gated-fixed-clock on this board, so reviewers of the U-Boot dtsi override can see the kernel-side rationale. Suggested by @rpardini on PR armbian#9848. Signed-off-by: SuperKali <hello@superkali.me>

SuperKali requested review from ColorfulRhino, HeyMeco, NicoD-SBC, Tonymac32, amazingfate, catalinii, efectn, igorpecovnik, paolosabatino and pyavitz as code owners May 18, 2026 19:19

github-actions Bot added 05 Milestone: Second quarter release size/small PR with less then 50 lines Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... labels May 18, 2026

HeyMeco approved these changes May 18, 2026

View reviewed changes

SuperKali merged commit 416a68c into armbian:main May 18, 2026
13 checks passed

github-actions Bot added the Ready to merge Reviewed, tested and ready for merge label May 18, 2026

github-actions Bot removed the Needs review Seeking for review label May 18, 2026

SuperKali deleted the followup/rock-5-itx-uboot-pcie-link-upstream branch May 18, 2026 19:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

rock-5-itx: link upstream kernel commit in pcie3 refclk u-boot patch#9861

rock-5-itx: link upstream kernel commit in pcie3 refclk u-boot patch#9861
SuperKali merged 1 commit into
armbian:mainfrom
OpenSource-YYT:followup/rock-5-itx-uboot-pcie-link-upstream

SuperKali commented May 18, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented May 18, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

Uh oh!

github-actions Bot commented May 18, 2026

Uh oh!

HeyMeco commented May 18, 2026

Uh oh!

SuperKali commented May 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

SuperKali commented May 18, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented May 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

Uh oh!

github-actions Bot commented May 18, 2026

Uh oh!

HeyMeco commented May 18, 2026

Uh oh!

SuperKali commented May 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

SuperKali commented May 18, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented May 18, 2026 •

edited

Loading